Commit graph

3377 commits

Author SHA1 Message Date
Leon Richardt 95c909b337
Better Highlights: Fix Wrong Color for Migrated Phrases (#1568)
* Better Highlights: Fix wrong color for migrated phrases

Prior to this commit, no default color was set when an "old" highlight
phrase (one added prior to #1320 / 5957551) was deserialized. This
commit makes highlight phrases uses the default self-highlight color for
these situations. This approach is reasonably sensible since that color
is also similar to the old highlight color.

Fixes #1565.

* Update default self-highlight color

The new default color was suggested in [1] by @RAnders00. Refer to the
link for further information.

[1]: https://github.com/Chatterino/chatterino2/issues/1565#issuecomment-590441625

* Theme: Remove highlight color

As highlight color is independent of the selected theme now, the member
has been removed from the `Theme` singleton. Instead, the fallback theme
color is defined in `HighlightPhrase` now.

Uses of `themes->messages.backgrounds.highlighted` have been replaced
with `HighlightPhrase::FALLBACK_COLOR` accordingly.

* Update src/controllers/highlights/HighlightPhrase.hpp

attempt to just remove constexpr

Co-Authored-By: Ruben Anders <ruben.anders@robotty.de>

* Initialize FALLBACK_COLOR outside header file

* Rename FALLBACK_COLOR to FALLBACK_HIGHLIGHT_COLOR

In preparation for the next commit introducing a new variable.

* Moved subscription highlight color into HighlightPhrase

* Use actual subscription color as a fallback

Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
Co-authored-by: Ruben Anders <ruben.anders@robotty.de>
2020-03-22 13:14:07 +01:00
pajlada 15cf8bfcfa
Don't set game to game id, always wait for the game name to be resolved (#1609)
Fixes #1606
2020-03-22 11:22:36 +01:00
Leon Richardt 17aa3f71cd
Remove Debug Output In Many Different Places (#1607)
* Application.cpp: Remove whisper debug output

* TwitchAccount.cpp: Remove AutoMod debug output

* BaseWindow.cpp: Remove mouse tracking debug output

* RunGui.cpp: Remove debug output for cleared cache items

* Notebook.cpp: Remove debug output for selected widgets

* LimitedQueue.hpp: Remove commented debug output

* IrcMessageHandler.cpp: Remove debug output when receiving whispers

* UserInfoPopup.cpp: Remove user name debug output

* ChannelView.cpp: Remove debug output when clicking a message

* Image.cpp: Remove commented debug output

* AttachedWindow.cpp: Remove commented debug output

* SplitOverlay.cpp: Remove commented debug output

* TwitchMessageBuilder.cpp: Remove debug output for highlights

* TwitchMessageBuilder.cpp: Remove debug output for blocked messages

* PubsubClient.cpp: Remove debug output on PubSub::listen

* PubsubClient.cpp: Remove debug output on PubSub::tryListen

* IncognitoBrowser.cpp: Remove debug output of browser command

* NativeMessaging.cpp: Remove debug output of message
2020-03-19 18:06:21 +01:00
Rasmus Karlsson 881c8892cf Move pull request template 2020-03-14 13:09:41 +01:00
pajlada 0f2355459d
Make ModBadgeElement a descendant of BadgeElement instead of EmoteElement (#1602)
this causes it to behave as it should, and not be scaled when emotes are
scaled. :)
2020-03-14 13:06:24 +01:00
pajlada 9a8b85e338
Twitch API: v5 to Helix migration (#1560)
There's a document in src/providers/twitch/api which describes how we interact with the Twitch API.
Keeping this up to date might be a healthy way for us to ensure we keep using the right APIs for the right job.
2020-03-14 12:13:57 +01:00
pajlada 2e39dd4d9b
macos ci: Replace create-dmg with builddmg (#1587) 2020-03-01 08:15:43 -05:00
Daniel Pasch be745862fd
Update contributors list (gempir) (#1583) 2020-03-01 06:20:59 -05:00
pajlada 20612a1381
Fix repeated signal connects on reconnect in irc server (#1576) 2020-03-01 06:05:08 -05:00
fourtf 26d3078def removed unused variables 2020-02-29 13:58:26 +01:00
mmb L 82354327e5
Add option for username tab completion only with an @ prefix (#1573)
* add an additional check for username completion without an @ prefix

* Changed setting name

* default userCompletionOnlyWithAt to false
2020-02-29 11:52:49 +01:00
fourtf a889d8d186
Disabled travis CI for now 2020-02-28 23:33:27 +01:00
fourtf 1e1a56bb87 fixed position of user icon head 2020-02-28 19:52:15 +01:00
fourtf 269d2ee67f improved user and settings icon 2020-02-28 19:48:04 +01:00
fourtf d83b597c75 removed unused function in SettingsDialog 2020-02-28 19:12:22 +01:00
fourtf b887f1c90e fix crash 2020-02-28 19:05:50 +01:00
fourtf ba5d842767 removed MutedChannelController 2020-02-28 19:04:25 +01:00
fourtf e537277fa8 did some more things and stuff 2020-02-23 23:07:28 +01:00
fourtf 5ad427bd61 moved some Settings from Application to Settings 2020-02-23 22:15:13 +01:00
fourtf f8a9850151 absorbed HighlightController into Application 2020-02-23 21:18:40 +01:00
fourtf d0a81f3fe7 refactored TaggedUsers and Ping 2020-02-23 20:34:00 +01:00
fourtf df91ea44c4 refactored ModeratinActions 2020-02-23 20:10:47 +01:00
fourtf 8ae9abb250 refactored IgnoredController 2020-02-23 20:01:35 +01:00
fourtf 89389608e9 removed compat class for SignalVector 2020-02-23 19:52:10 +01:00
fourtf 7e49371ba1 fixed formatting 2020-02-23 19:44:37 +01:00
fourtf 2ebe07bace removed compat functions in SignalVector 2020-02-23 19:44:13 +01:00
fourtf e2c493f369 removed compat aliases for SignalVector 2020-02-23 19:37:02 +01:00
fourtf 843e2ad994 refactored HighlightController 2020-02-23 19:31:43 +01:00
fourtf 4a5dc80bc6 some more refactoring 2020-02-23 17:45:59 +01:00
fourtf e1838154ff refactored SignalVector 2020-02-23 17:11:15 +01:00
pajlada 2b5c6ffe33
Remove chatroom code (#1561)
People who had chatrooms still open should notice no difference at all, since it will just try to join a channel with the chatroom name.

Documentation for the closing/deprecation of twitch chat rooms:
    https://discuss.dev.twitch.tv/t/rooms-are-closing-how-it-affects-the-api-and-irc/22996
    https://dev.twitch.tv/docs/change-log (see 2020-01-10 entry)
2020-02-22 06:05:36 -05:00
fourtf 03cf6e81ff fixed spaces and margins in general settings 2020-02-21 03:01:48 +01:00
fourtf 5a2633ef5c fixed bug 2020-02-21 02:16:35 +01:00
fourtf a2d21510ac
Update CHANGELOG.md 2020-02-21 02:13:31 +01:00
fourtf 927ee09221 reordered resize call 2020-02-21 02:07:34 +01:00
fourtf 70e5bd1bfd lazily initialize settings pages 2020-02-21 01:59:58 +01:00
fourtf 78ca0cb84f moved settings tab icons to SettingsDialog 2020-02-21 01:22:50 +01:00
fourtf 39d40d6db6 some settings refactorings 2020-02-21 01:17:22 +01:00
fourtf fbbf34878f getSettingsPage -> page 2020-02-21 00:46:19 +01:00
fourtf 0bb112a3c2 improved performance of opening the settings dialog 2020-02-20 23:47:25 +01:00
fourtf 4a69095d5f fix 2020-02-20 23:43:54 +01:00
fourtf d6c3c99605 list settings can be reordered now 2020-02-20 23:16:46 +01:00
fourtf 78532a01ec
Merge pull request #1558 from leon-richardt/fix-selectable-default-columns
Make pre-defined highlight columns unselectable
2020-02-20 19:55:57 +01:00
Leon Richardt d0839ac36e
Make pre-defined highlight columns unselectable
Fixes #1539.
2020-02-20 00:10:10 +01:00
fourtf 6229b2f434 sync gif emotes of same length 2020-02-16 14:24:11 +01:00
pajlada 59296075e8
Fix the CI by downgrading install-qt-action version (#1554) 2020-02-15 12:04:05 -05:00
Rasmus Karlsson 7a08d73434 Fix preview on hover not working when Animated emotes options was disabled.
Fixes #1546

This change introduces a "window timer" that runs every 100ms that we
use to update the pixmap if necessary, since there is no signal for "let
me know when this image is done loading".
2020-02-15 17:16:10 +01:00
Rasmus Karlsson 64c58e724a Use same sorting method in emote popup as in the completion model
Fixes #1549
2020-02-15 15:52:42 +01:00
Rasmus Karlsson b93de7c0f6 Add some debug output in our project file 2020-02-15 15:19:16 +01:00
Rasmus Karlsson b5764c6a1f Remove stupid assert in PubSubClient
Fixes #1550
2020-02-15 14:49:22 +01:00