noury/mirror-chatterino2
1
0
Fork 0
mirror of https://github.com/Chatterino/chatterino2.git synced 2024-11-13 19:49:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(Split): always refresh tab when channel is set (#3849)

Browse source 
Fixes #3845

Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
This commit is contained in:
Leon Richardt 2022-07-07 18:52:15 +02:00 committed by GitHub
parent 3341a44fb5
commit 53a625e26e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -40,6 +40,7 @@
- Bugfix: Add icon in the CMake macOS bundle. (#3832) - Bugfix: Add icon in the CMake macOS bundle. (#3832)
- Bugfix: Adopt popup windows in order to force floating behavior on some window managers. (#3836) - Bugfix: Adopt popup windows in order to force floating behavior on some window managers. (#3836)
- Bugfix: Fix split focusing being broken in certain circumstances when the "Show input when it's empty" setting was disabled. (#3838) - Bugfix: Fix split focusing being broken in certain circumstances when the "Show input when it's empty" setting was disabled. (#3838)
- Bugfix: Always refresh tab when a contained split's channel is set. (#3849)
- Dev: Rewrite LimitedQueue (#3798) - Dev: Rewrite LimitedQueue (#3798)
- Dev: Overhaul highlight system by moving all checks into a Controller allowing for easier tests. (#3399, #3801, #3835) - Dev: Overhaul highlight system by moving all checks into a Controller allowing for easier tests. (#3399, #3801, #3835)
- Dev: Use Game Name returned by Get Streams instead of querying it from the Get Games API. (#3662) - Dev: Use Game Name returned by Get Streams instead of querying it from the Get Games API. (#3662)

2
src/widgets/splits/Split.cpp
View file

@ -699,6 +699,7 @@ void Split::setChannel(IndirectChannel newChannel)
}); });
this->channelChanged.invoke(); this->channelChanged.invoke();
this->actionRequested.invoke(Action::RefreshTab);
// Queue up save because: Split channel changed // Queue up save because: Split channel changed
getApp()->windows->queueSave(); getApp()->windows->queueSave();
@ -743,7 +744,6 @@ void Split::showChangeChannelPopup(const char *dialogTitle, bool empty,
if (dialog->hasSeletedChannel()) if (dialog->hasSeletedChannel())
{ {
this->setChannel(dialog->getSelectedChannel()); this->setChannel(dialog->getSelectedChannel());
this->actionRequested.invoke(Action::RefreshTab);
} }
callback(dialog->hasSeletedChannel()); callback(dialog->hasSeletedChannel());