From 53a625e26e290a13f5632660c2c0f3dea62a74d3 Mon Sep 17 00:00:00 2001 From: Leon Richardt Date: Thu, 7 Jul 2022 18:52:15 +0200 Subject: [PATCH] fix(Split): always refresh tab when channel is set (#3849) Fixes #3845 Co-authored-by: pajlada --- CHANGELOG.md | 1 + src/widgets/splits/Split.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 41bb85ac8..17fb859e3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,7 @@ - Bugfix: Add icon in the CMake macOS bundle. (#3832) - Bugfix: Adopt popup windows in order to force floating behavior on some window managers. (#3836) - Bugfix: Fix split focusing being broken in certain circumstances when the "Show input when it's empty" setting was disabled. (#3838) +- Bugfix: Always refresh tab when a contained split's channel is set. (#3849) - Dev: Rewrite LimitedQueue (#3798) - Dev: Overhaul highlight system by moving all checks into a Controller allowing for easier tests. (#3399, #3801, #3835) - Dev: Use Game Name returned by Get Streams instead of querying it from the Get Games API. (#3662) diff --git a/src/widgets/splits/Split.cpp b/src/widgets/splits/Split.cpp index ab5af96cb..ae78e6001 100644 --- a/src/widgets/splits/Split.cpp +++ b/src/widgets/splits/Split.cpp @@ -699,6 +699,7 @@ void Split::setChannel(IndirectChannel newChannel) }); this->channelChanged.invoke(); + this->actionRequested.invoke(Action::RefreshTab); // Queue up save because: Split channel changed getApp()->windows->queueSave(); @@ -743,7 +744,6 @@ void Split::showChangeChannelPopup(const char *dialogTitle, bool empty, if (dialog->hasSeletedChannel()) { this->setChannel(dialog->getSelectedChannel()); - this->actionRequested.invoke(Action::RefreshTab); } callback(dialog->hasSeletedChannel());