mirror of
https://github.com/Chatterino/chatterino2.git
synced 2024-11-13 19:49:51 +01:00
a9080ceb3c
* Proof of Concept for Quick Switcher * Fix crash when suggestions are empty * QuickSwitcher: Use tab name instead of a single channel * Rebase later * Add missing include for <functional> * Move QuickSwitcher related classes into own subfolder * Refactor switcher list items Now, items are responsible for taking the right action when selected in the switcher list. This should allow for more focused code and responsibilities. * Add note about memory management * Add option to open channel in a new tab * Add support for using the mouse * Spawn switcher popup in the middle of the window Works reliably on i3 at least. Might need some additional testing on other WMs (and especially on Windows!). * Add some icons for switcher items Note that the final design of the list is not final but I do plan to incorporate these in the future. * Set Qt::Dialog window flag on switcher popup Prevents tiling window managers like i3 from trying to tile the window. * Rename "SwitcherItem" to "AbstractSwitcherItem" * Add comments about what items are inserted * Use custom model and view Still missing: Currently selected item is not highlighted yet. You can move between selected items with tab and arrow keys though. * Add helper function to convert QVariant to AbstractSwitcherItem * * Remove useless constant * Highlight currently selected switcher item * Use a different method for centering QuickSwitcherPopup window * QuickSwitcherModel: Add documentation * Add default parameter to QuickSwitcherModel::rowCount * QuickSwitcherPopup: Add comments * Remove outdated TODO * QuickSwitcherModel: Init vector with default capacity * Remove outdated comment * Add comment about 0 ms timeout interval * NewTabItem: Simplify interface * Only fetch opened splits once This is better than the prior approach since opened splits cannot change anyways while the switcher is open. * Use SplitContainer to pass information instead of custom type * Allow searching for tab titles as well Before this commit, only channel names could be searched. * Refactor switcher item interface to be more flexible Also show tab name and channel name in the switcher list. * Add documentation for AbstractSwitcherItem * Add documentation for NewTabItem * Add comments about {begin,end}{Insert,Remove}Rows * Remove unused method * Replace magic size with named constant * Add change log entry Co-authored-by: fourtf <tf.four@gmail.com>
33 lines
792 B
C++
33 lines
792 B
C++
#pragma once
|
|
|
|
#include "widgets/dialogs/switcher/AbstractSwitcherItem.hpp"
|
|
|
|
namespace chatterino {
|
|
|
|
class NewTabItem : public AbstractSwitcherItem
|
|
{
|
|
public:
|
|
/**
|
|
* @brief Construct a new NewTabItem that opens a passed channel in a new
|
|
* tab.
|
|
*
|
|
* @param channelName name of channel to open
|
|
*/
|
|
NewTabItem(const QString &channelName);
|
|
|
|
/**
|
|
* @brief Open the channel passed in the constructor in a new tab.
|
|
*/
|
|
virtual void action() override;
|
|
|
|
virtual void paint(QPainter *painter, const QRect &rect) const;
|
|
virtual QSize sizeHint(const QRect &rect) const;
|
|
|
|
private:
|
|
static constexpr const char *TEXT_FORMAT = "Open channel \"%1\" in new tab";
|
|
QString channelName_;
|
|
QString text_;
|
|
};
|
|
|
|
} // namespace chatterino
|