Merge a9b446ffc7 into 867e3f3ab0

src/messages/MessageBuilder.cpp

@@ -2759,7 +2759,7 @@ void MessageBuilder::appendTwitchBadges(const QVariantMap &tags,
 
     if (this->message().flags.has(MessageFlag::SharedMessage))
     {
-        QString sourceId = tags["source-room-id"].toString();
+        const QString sourceId = tags["source-room-id"].toString();
         std::optional<QString> sourceName;
         if (twitchChannel->roomId() == sourceId)
         {
@@ -2773,9 +2773,14 @@ void MessageBuilder::appendTwitchBadges(const QVariantMap &tags,
 
         if (sourceName.has_value())
         {
-            this->emplace<BadgeElement>(makeSharedChatBadge(sourceName.value()),
-                                        MessageElementFlag::BadgeSharedChannel)
-                ->setLink({Link::UserInfo, sourceName.value()});
+            const auto &name = sourceName.value();
+            auto *badge = this->emplace<BadgeElement>(
+                makeSharedChatBadge(name),
+                MessageElementFlag::BadgeSharedChannel);
+            if (!name.isEmpty())
+            {
+                badge->setLink({Link::UserInfo, name});
+            }
         }
     }
 

src/providers/twitch/TwitchIrcServer.hpp

@@ -100,6 +100,11 @@ public:
     std::shared_ptr<Channel> getChannelOrEmptyByID(
         const QString &channelID) override;
 
+    /**
+     * Obtains the channel login name associated with the passed ID,
+     * so that Shared Chat messages can provide source channel context.
+     * Can yield an empty string if a helix request is already in-flight.
+     */
     std::optional<QString> getOrPopulateChannelCache(
         const QString &channelId) override;