Merge e537fca186 into 90211cca55

src/common/Channel.hpp

@@ -98,8 +98,7 @@ public:
     /// Removes all messages from this channel and invokes #messagesCleared
     void clearMessages();
 
-    [[deprecated("Use findMessageByID instead")]] MessagePtr findMessage(
+    MessagePtr findMessage(QString messageID);
-        QString messageID);
     MessagePtr findMessageByID(QStringView messageID) final;
 
     bool hasMessages() const;

src/messages/MessageSink.hpp

@@ -5,7 +5,6 @@
 #include "messages/MessageFlag.hpp"
 
 #include <memory>
-#include <optional>
 
 class QStringView;
 class QTime;

src/providers/twitch/IrcMessageHandler.cpp

@@ -369,8 +369,8 @@ void IrcMessageHandler::parsePrivMessageInto(
     }
 
     addMessage(message, sink, channel,
-               unescapeZeroWidthJoiner(message->content()),
+               unescapeZeroWidthJoiner(message->content()), false,
-               *getApp()->getTwitch(), false, message->isAction());
+               message->isAction());
 
     if (message->tags().contains(u"pinned-chat-paid-amount"_s))
     {
@@ -675,8 +675,7 @@ void IrcMessageHandler::parseUserNoticeMessageInto(Communi::IrcMessage *message,
         // Messages are not required, so they might be empty
         if (!content.isEmpty())
         {
-            addMessage(message, sink, channel, content, *getApp()->getTwitch(),
+            addMessage(message, sink, channel, content, true, false);
-                       true, false);
         }
     }
 
@@ -956,12 +955,11 @@ void IrcMessageHandler::handlePartMessage(Communi::IrcMessage *message)
 }
 
 void IrcMessageHandler::addMessage(Communi::IrcMessage *message,
-                                   MessageSink &sink, TwitchChannel *chan,
+                                   MessageSink &sink, TwitchChannel *channel,
-                                   const QString &originalContent,
+                                   const QString &originalContent, bool isSub,
-                                   ITwitchIrcServer &twitch, bool isSub,
                                    bool isAction)
 {
-    assert(chan);
+    assert(channel);
 
     MessageParseArgs args;
     if (isSub)
@@ -970,7 +968,7 @@ void IrcMessageHandler::addMessage(Communi::IrcMessage *message,
         args.trimSubscriberUsername = true;
     }
 
-    if (chan->isBroadcaster())
+    if (channel->isBroadcaster())
     {
         args.isStaffOrBroadcaster = true;
     }
@@ -994,13 +992,13 @@ void IrcMessageHandler::addMessage(Communi::IrcMessage *message,
     if (!rewardId.isEmpty() &&
         sink.sinkTraits().has(
             MessageSinkTrait::RequiresKnownChannelPointReward) &&
-        !chan->isChannelPointRewardKnown(rewardId))
+        !channel->isChannelPointRewardKnown(rewardId))
     {
         // Need to wait for pubsub reward notification
         qCDebug(chatterinoTwitch) << "TwitchChannel reward added ADD "
                                      "callback since reward is not known:"
                                   << rewardId;
-        chan->addQueuedRedemption(rewardId, originalContent, message);
+        channel->addQueuedRedemption(rewardId, originalContent, message);
         return;
     }
     args.channelPointRewardId = rewardId;
@@ -1014,9 +1012,9 @@ void IrcMessageHandler::addMessage(Communi::IrcMessage *message,
         it != tags.end())
     {
         const QString replyID = it.value().toString();
-        auto threadIt = chan->threads().find(replyID);
+        auto threadIt = channel->threads().find(replyID);
         std::shared_ptr<MessageThread> rootThread;
-        if (threadIt != chan->threads().end() && !threadIt->second.expired())
+        if (threadIt != channel->threads().end() && !threadIt->second.expired())
         {
             // Thread already exists (has a reply)
             auto thread = threadIt->second.lock();
@@ -1037,7 +1035,7 @@ void IrcMessageHandler::addMessage(Communi::IrcMessage *message,
                 replyCtx.thread = newThread;
                 rootThread = newThread;
                 // Store weak reference to thread in channel
-                chan->addReplyThread(newThread);
+                channel->addReplyThread(newThread);
             }
         }
 
@@ -1054,8 +1052,8 @@ void IrcMessageHandler::addMessage(Communi::IrcMessage *message,
             }
             else
             {
-                auto parentThreadIt = chan->threads().find(parentID);
+                auto parentThreadIt = channel->threads().find(parentID);
-                if (parentThreadIt != chan->threads().end())
+                if (parentThreadIt != channel->threads().end())
                 {
                     auto thread = parentThreadIt->second.lock();
                     if (thread)
@@ -1077,7 +1075,7 @@ void IrcMessageHandler::addMessage(Communi::IrcMessage *message,
 
     args.allowIgnore = !isSub;
     auto [msg, alert] = MessageBuilder::makeIrcMessage(
-        chan, message, args, content, messageOffset, replyCtx.thread,
+        channel, message, args, content, messageOffset, replyCtx.thread,
         replyCtx.parent);
 
     if (msg)
@@ -1094,7 +1092,7 @@ void IrcMessageHandler::addMessage(Communi::IrcMessage *message,
             (!getSettings()->hideSimilar &&
              getSettings()->shownSimilarTriggerHighlights))
         {
-            MessageBuilder::triggerHighlights(chan, alert);
+            MessageBuilder::triggerHighlights(channel, alert);
         }
 
         const auto highlighted = msg->flags.has(MessageFlag::Highlighted);
@@ -1103,12 +1101,12 @@ void IrcMessageHandler::addMessage(Communi::IrcMessage *message,
         if (highlighted && showInMentions &&
             sink.sinkTraits().has(MessageSinkTrait::AddMentionsToGlobalChannel))
         {
-            twitch.getMentionsChannel()->addMessage(msg,
+            getApp()->getTwitch()->getMentionsChannel()->addMessage(
-                                                    MessageContext::Original);
+                msg, MessageContext::Original);
         }
 
         sink.addMessage(msg, MessageContext::Original);
-        chan->addRecentChatter(msg->displayName);
+        channel->addRecentChatter(msg->displayName);
     }
 }
 

src/providers/twitch/IrcMessageHandler.hpp

@@ -60,8 +60,9 @@ public:
     void handlePartMessage(Communi::IrcMessage *message);
 
     static void addMessage(Communi::IrcMessage *message, MessageSink &sink,
-                           TwitchChannel *chan, const QString &originalContent,
+                           TwitchChannel *channel,
-                           ITwitchIrcServer &twitch, bool isSub, bool isAction);
+                           const QString &originalContent, bool isSub,
+                           bool isAction);
 
 private:
     static float similarity(const MessagePtr &msg,

src/providers/twitch/TwitchChannel.cpp

@@ -453,7 +453,7 @@ void TwitchChannel::addChannelPointReward(const ChannelPointReward &reward)
                 {
                     IrcMessageHandler::instance().addMessage(
                         msg.message.get(), *this, this, msg.originalContent,
-                        *server, false, false);
+                        false, false);
                     return true;
                 }
                 return false;