Commit graph

1004 commits

Author SHA1 Message Date
Leon Richardt f2b2e3142f Implement simpler fix for emote completion bug
This commit implements a simpler fix for the problem described in #1209.
The setting's signal is connected to a reset of `completionInProgress_`
so that the completion model is updated on the next word already.

This commit also removes the older approach tackling this issue.
2019-08-18 21:37:20 +02:00
Leon Richardt be5318f275 Fix emote completion bug
This commit fixes a bug that would occur when changing the completion
mode from prefix-only to substring while mid-completion.
In that case, the suggestion list was not updated until the next
completion attempt.

This is fixed by forcing a suggestion list refresh whenever the
setting's checkbox is updated.
2019-08-17 21:31:31 +02:00
Leon Richardt 58d892a8c2 Make Emote Tab Completion Search for Substrings (#1204)
* Make emote tab completion search for substrings

Previously, tab completion only searched for emotes that start
with the current prefix under the cursor. This commit makes tab
completion look for the current prefix as a substring in any position,
not just the start.

Examples:
    * In forsen's channel, tabbing on "pls" will cycle through "DonaldPls", "forsenPls",
    "GachiPls", "nyanPls" and "SourPls".

    * As a forsen subscriber, tabbing on "sen1" will complete to "forsen1".

    * As a pajlada subscriber, tabbing on "shrug" will cycle through
    "pajaShrugL" and "pajaShrugR". (Unless you are in a channel with
    more "shrug" emotes, of course.)

* Add a setting for prefix and substring completion

This commit adds a setting under the "Miscellaneous" section to allow
user to choose whether they want prefix-only or substring emote
completion.

The QCompleter filter mode and `addString` function are now chosen
according to the user's setting.

* Improve description of emote completion setting

Also reintroduce a blank line that went missing.
2019-08-17 17:17:38 +02:00
pajlada 3dcbe89e28
Merge pull request #1208 from leon-richardt/fix-account-popup
Fix "Manage Accounts" button
2019-08-17 11:05:09 +02:00
Leon Richardt 4a1712f9a2 Fix "Manage Accounts" button
This commit fixes the unresponsiveness of the "Manage Account" button
(described in #1188).

Apparently, focus was lost when pressing down the mouse button. This is
circumvented by setting the focus policy of the button to `Qt::NoFocus`.
The button then works as expected and opens the "Account" page in the
preferences.
2019-08-17 01:35:24 +02:00
23rd f9e9ed8ed0 Improved stream header creation. 2019-08-16 23:40:30 +03:00
Mateusz Ż eb38b53c04 Fix Settings UI inconsistencies (#1202)
* Move "About" tab in Settings

* Resize Settings window

This prevents from spawning horizontal scroll (which is caused by too long line
in "Attributions" group)

* Fix "show license" link width

If you clicked empty space next to link application assumed you clicked link.
I fixed that by using QLabels instead of SignalLabel (there's something "wrong"
with them, but I couldn't find what)
2019-08-14 20:03:42 +02:00
fourtf 4679fd6753 gcc Pepega 2019-08-13 18:48:22 +02:00
fourtf 7bf5a79f8a Delete emote popup when it is closed. 2019-08-13 16:39:22 +02:00
Rasmus Karlsson cd5972522b reformat 2019-08-11 21:08:18 +02:00
23rd da039bfdfa Added setting to colorize usernames who have not set own color. 2019-08-11 19:48:43 +03:00
23rd fdb0b62dee Fixed switching tabs using trackpad scroll. 2019-08-10 13:34:59 +02:00
pajlada 0c245fbc4e
Merge pull request #1178 from 23rd/patch-29-mac-ctrl-tab
Added new submenu in menu bar for OS X to switch tabs with hotkeys.
2019-08-10 13:22:33 +02:00
pajlada 989dad1a6d
Merge pull request #1179 from 23rd/patch-30-simplified-tab-hotkeys
Moved to one place and simplified hotkeys of switching tabs.
2019-08-10 13:18:11 +02:00
23rd 34841543c7 Replaced repetitive code of Ctrl+1-8 hotkeys with single loop. 2019-08-04 17:57:34 +03:00
23rd 838fd6bab6 Added ability to open last tab with Ctrl+9. (Chromium behaviour.)
- Fixed #1106.
2019-08-04 17:23:41 +03:00
23rd 485715ef30 Moved to one place and simplified hotkeys of switching tabs. 2019-08-04 17:03:58 +03:00
23rd 79a87e740a Added new submenu in menu bar for OS X to switch tabs with hotkeys.
- Fixed #1176.
 - https://bugreports.qt.io/browse/QTBUG-8596
2019-08-04 16:43:35 +03:00
fourtf aac27c2a0d Fixes #1162 2019-07-31 23:03:55 +02:00
fourtf fff979b3c0 lock SignalVector with shared_lock to allow reading on other threads 2019-07-31 22:50:12 +02:00
fourtf 4e4c7d4c0b Set default username boldness to DemiBold (63) 2019-07-28 20:24:39 +02:00
Rasmus Karlsson 3679125e2f Reformat 2019-07-28 13:21:54 +02:00
Rasmus Karlsson 954b1b138a Add a setting for the timeout stack style:
"Stack" is the default behaviour, it will search 20 messages up and 5
seconds back in time to stack the timeout.
"Stack sparingly" will try to do the same, but only if the user has not
typed a message inbetween the this and the last timeout.

Fixes #1157
2019-07-28 13:21:54 +02:00
Rasmus Karlsson 1ae66f3b7d Run newline replacer before sending message input to command executor
Fixes #1123
2019-07-28 12:19:33 +02:00
fourtf 39f44d74b3 Added autorun on boot setting for windows. 2019-07-23 23:56:14 +02:00
Rasmus Karlsson 628c64d138 Move "How to" options to their own sub-menu 2019-07-21 13:01:35 +02:00
TranRed a768515849 Added Subscribe option to channel menu
Added the option to visit the subscription page of a channel from chatterino
2019-07-16 21:59:04 +02:00
pajlada fb6a55847d
Merge pull request #1140 from TranRed/inlineWhisperHighlight
Added setting and functionality to highlight inline whispers
2019-07-14 19:32:09 +02:00
pajlada 645f7c74d0
Merge pull request #1139 from RAnders00/patch-4
Add VIP to settings description of badge toggle
2019-07-14 18:51:30 +02:00
pajlada dd353a56a1
Merge pull request #1136 from TranRed/viewerlist-quickfix
Make viewer list float by default
2019-07-14 18:45:50 +02:00
TranRed d725155569 Added setting and functionality to highlight inline whispers
Inline whispers will be displayed with highlighted background color.

New Flag needed to differentiate between normal whisper (highlighted) and whisper with mention.
2019-07-14 16:35:32 +02:00
Ruben Anders 667d2dbdda
Add VIP to settings description of badge toggle 2019-07-14 15:31:40 +02:00
TranRed 32d4383d5f Make button "Manage Accounts" open the Accounts tab
fixes #1135
2019-07-14 12:36:53 +02:00
TranRed 6c14fca216 Make viewer list float
- makes viewer list float
- changed Vip to VIP
- added myself as contributor
2019-07-14 11:43:57 +02:00
Rasmus Karlsson c483a87605 Right-clicking split header now opens the same menu as the hamburger icon
Fixes #1131
2019-07-13 12:17:42 +02:00
pajlada fe69dfb5e0
Merge pull request #1108 from tsoding/1100
(#1100) Clean TooltipPreviewImage on SplitHeader enterEvent
2019-06-23 09:32:55 +02:00
rexim 4cde28f29b (#1100) Clean TooltipPreviewImage on SplitHeader enterEvent
Supa quick fix for #1100

Looks like this bug may come back in other places where we use
`TooltipWidget`. For a permanent fix we have to go through all of the
places that touch `TooltipWidget` and check if they clean the preview
image correctly.

It would be better to merge TooltipPreviewImage and TooltipWidget
together and change `TooltipWidget::setText` to be

```c++
void TooltipWidget::setText(const QString &text, ImagePtr image = ptrnull);
```

But it's impossible right now, because TooltipWidget is located in
appbase and `ImagePtr` is not visible there (it's located in the main
chatterino repo). Plus we also need an access to
`getApp()->windows->gifRepaintRequested`.

First step in implementing the permanent fix would be moving
TooltipWidget to chatterino from appbase.

Any thoughts on the situation?
2019-06-22 21:39:59 +07:00
Rasmus Karlsson 27114c5154 Restore option to disable emote images
Condensed into a single option, which will disable/enable all emote and emoji images

Also moved badges into their own element
2019-06-22 14:34:54 +02:00
Rasmus Karlsson 9cb5e3abb3 Fix a bug where tabbing too early would break any future tab completions
Fixes #1107
2019-06-22 13:16:16 +02:00
Rasmus Karlsson 8d85b9c071 Override Home and End behaviour.
Home now brings you to the beginning of the message (previously of the line)
End now brings you to the end of the message (previously of the line)
2019-06-21 22:22:43 +02:00
Rasmus Karlsson 406c0b9af8 Stop "up arrow" keyboard event from propagating furthern when we're going through message history
Fixes #1102
2019-06-21 22:15:17 +02:00
apa420 70bb63d20f Added option for shift, used clang and made setting uneditable 2019-06-11 22:54:20 +02:00
rexim f362548e28 (#976) Use int for emotesTooltipPreview 2019-06-12 02:05:18 +07:00
rexim 244252f610 (#976) Make TooltipPreviewImage non-copyable 2019-06-12 02:04:57 +07:00
rexim 483e177a39 (#976) Fix compilation errors
Which were not visible because of incremental build or something
2019-06-12 01:16:56 +07:00
rexim 3838157d82 Extract TooltipWidget updating into a separate class 2019-06-12 01:03:04 +07:00
rexim 3f4d3ce14a (#976) Make currentPreviewImage shareable between ChannelView-s 2019-06-12 00:22:26 +07:00
rexim e1a901aa98 Adjust tooltip size after setting the text 2019-06-11 23:20:04 +07:00
rexim 0fb16d150b Preview images instead of emotes 2019-06-11 23:20:04 +07:00
rexim a84716547b Animate gifs in the tooltip preview 2019-06-11 23:20:04 +07:00