Commit graph

15 commits

Author SHA1 Message Date
Leon Richardt
540870f9fe
[Fix] Make SearchPopup a BasePopup (#2182) 2020-11-15 11:07:20 +01:00
dnsge
4199a01b96 Advanced channel filters (#1748)
Adds custom channel filters complete with their own mini-language. Filters can be created in settings, and applied by clicking the three dots to open the Split menu and selecting "Set filters".
2020-10-18 15:18:20 +02:00
Rasmus Karlsson
55080bd354 Add a "BasePopup" class, which helps add default functionality to any popups (like the search popup) 2019-12-14 12:58:15 +01:00
Leon Richardt
720e5aa25f Improvements to Message Search (#1237)
* Ran clang-format

* Implement user-specific search in message history

This functionality was originally requested in #1236.

This commit changes the SearchPopup::performSearch method so that only
messages from specific users can be shown.

In order to filter for a specific user, enter their username with a
leading '@' in the search popup. You can also add an additional search
phrase which will also be considered in the search.

* Naive implementation for "from:" tags

Rebase later?

* Cleverer (?) version using Predicates

Commit adds two POC predicates: one for the author of messages, and one
for substring search in messages.

Problems/TODOs:
* Best way to register new predicates?
* Clean up tags (e.g. "from:") or not?
* Test combinations of different predicates

* Add a predicate to check for links in messages

* Remove a dumb TODO

* Rewrite SearchPopup::performSearch to be cleaner

* Ran clang-format on all files

* Remove TODO I missed earlier

* Forgot to run clang-format

peepoSadDank

* Re-use {}-initialization

Was accidentally removed when fixing earlier merge conflict.

* Does this fix line endings?

No diffs are shown locally, hopefully Git doesn't lie to me.

* Rename "predicates" directory to "search"

Resolving one conversation in the review of #1237.

* Use LinkParser in LinkPredicate

Resolving a conversation in the review of #1237.

* Predicates: Use unique_ptr instead of shared_ptr

Resolves a conversation in the review of #1237.

* Refactor of SearchPopup and AuthorPredicate

Resolving some points from the review in #1237.

* Moved parsing of comma-seperated values into AuthorPredicate
  constructor.
* Rewrite SearchPopup::parsePredicates as suggested.
* Deleted now redundant methods in SearchPopup.

* MessagePredicate::appliesTo now takes a Message&

... instead of a MessagePtr.

This resolves a conversation in the review of #1237.

* Run clang-format on two files I missed

* AuthorPredicate: Check for displayName & loginName

Resolving conversation on #1237.
2019-09-09 15:21:49 +02:00
Leon Richardt
b06eb9df83 Normalize line endings in already existing files 2019-09-08 22:27:57 +02:00
fourtf
a268abfd4c Allow searching in LogsPopup 2019-09-04 00:29:58 +02:00
fourtf
67aadfe61f Fixes #1218 Usercard link from search popup 2019-08-21 01:19:41 +02:00
Alexandr Kondratev
14eb302c3d Close search popup window on Escape pressed 2019-05-06 21:16:40 +02:00
fourtf
44f5a15da3 turning a lot of includes into forward declares 2018-08-11 22:23:06 +02:00
fourtf
280bb4cf8e Renamed private members 2018-07-06 19:24:35 +02:00
fourtf
5604ae6a67 removed functions from SettingsManager that shouldn't be there 2018-06-28 19:38:57 +02:00
fourtf
54eb07e116 removed namespaces 2018-06-26 17:06:17 +02:00
fourtf
2df0566492 removed namespaces 2018-06-26 16:37:59 +02:00
fourtf
a9bf9cf722 rename #3 2018-06-26 14:09:39 +02:00
fourtf
c9722b9780 rename #2 2018-06-26 13:24:55 +02:00
Renamed from src/widgets/helper/_SearchPopup.hpp (Browse further)