Commit graph

24 commits

Author SHA1 Message Date
nerix 93a9e41d31
Cleanup Theme-related Code (#4450) 2023-03-17 19:53:03 +00:00
pajlada fdb0a1582c
SplitContainer refactor (#4261)
* Remove unused include util/Helpers.hpp

* SplitContainer::setTag fix parameter naming

* autofy/constify where possible

* More const auto ptr magicifying

* Make SplitNode::Type an enum class

* Move QuickSwitcherPopup includes from header to source file

* Remove unused DropRegion code

* use empty() instead of size() == 0

* Add curly braces everywhere

* Remove useless reinterpret_cast

It was casting Node* to Node*

* Clarify that the connect is QObject::connect

* SplitContainer::setSelected fix parameter naming

* Rename function variables to remove unneccesary underscore

Also move addSpacing parameter out of the layout function

* emplace_back where possible

* Name parameters

* Remove ineffective const from return type

* Make node getters const

* Flatten Node::releaseSplit

* Rename in-function variable to match code style

* [ACTUAL CODE CHANGE/MOVE] Move clamp logic to its own function

* name params

* applyFromDescriptorRecursively: rename node param to baseNode

* [ACTUAL CODE CHANGE/MOVE] Remove the many overloads for append/insertSplit

This utilizes the C++20 designed initializers aggregate initialization feature

* Remove unused includes

* [ACTUAL CODE CHANGE] Clean up dragging logic

There's no need to keep a pointer around to which split is being
dragged, it's already stored in the QDropEvent source()

* UNRELATED .clang-tidy: Only suggest UPPER_CASE for constant global variables

* Remove unused SplitContainer::getSplitCount function

* Use std::max in Node's clamp function

* Remove test code

* DraggedSplit.hpp: remove unused include

* Split `setDraggingSplit` into two functions, `startDraggingSplit` and `stopDraggingSplit`
2022-12-25 11:09:25 +00:00
pajlada 032f290767
Sort and force grouping of includes (#4172)
This change enforces strict include grouping using IncludeCategories

In addition to adding this to the .clang-format file and applying it in the tests/src and src directories, I also did the following small changes:

    In ChatterSet.hpp, I changed lrucache to a <>include
    In Irc2.hpp, I change common/SignalVector.hpp to a "project-include"
    In AttachedWindow.cpp, NativeMessaging.cpp, WindowsHelper.hpp, BaseWindow.cpp, and StreamerMode.cpp, I disabled clang-format for the windows-includes
    In WindowDescriptors.hpp, I added the missing vector include. It was previously not needed because the include was handled by another file that was previously included first.
    clang-format minimum version has been bumped, so Ubuntu version used in the check-formatting job has been bumped to 22.04 (which is the latest LTS)
2022-11-27 19:32:53 +01:00
pajlada 2f49b23875
Add ability to disable precompiled headers with CMake (#2727) 2021-05-08 15:57:00 +02:00
Paweł d1a10d3c1f
Fixed deprecated method QFlags::Zero (#2508)
Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
2021-03-13 16:27:13 +01:00
fourtf 1e1a56bb87 fixed position of user icon head 2020-02-28 19:52:15 +01:00
fourtf 269d2ee67f improved user and settings icon 2020-02-28 19:48:04 +01:00
fourtf 9874bd779a formatted all files with clang 9 2019-09-26 00:51:05 +02:00
fourtf 25aab4cdeb rename tab on double click 2018-10-22 19:57:02 +02:00
fourtf 3db0b5f95c open settings when right clicking moderation button 2018-10-21 16:13:26 +02:00
fourtf e259b9e39f added brace wrapping after if and for 2018-10-21 13:43:02 +02:00
fourtf 31b9d497d7 change color of + button while dragging split 2018-10-09 19:22:07 +02:00
fourtf 44f5a15da3 turning a lot of includes into forward declares 2018-08-11 22:23:06 +02:00
fourtf d89b62692a refined SplitHeader 2018-08-08 15:35:54 +02:00
fourtf f71ff08e68 changed to 80 max column 2018-08-06 21:17:03 +02:00
fourtf b639604a47 refactored BaseWidget 2018-07-06 17:11:37 +02:00
fourtf 3d7926cac1 added the update download button for linux/mac (updates don't work tho
so it doesn't show)
2018-07-05 13:25:10 +02:00
fourtf 86347dc63e renamed Themes to Theme 2018-06-28 20:03:04 +02:00
fourtf 2df142bd50 renamed *Manager files 2018-06-28 19:46:45 +02:00
fourtf 08e552f5f6 ran clang-format on all files 2018-06-26 17:20:03 +02:00
fourtf 2df0566492 removed namespaces 2018-06-26 16:37:59 +02:00
fourtf 22f528cd21 put all split widgets inside the same directory 2018-06-26 14:39:22 +02:00
fourtf a9bf9cf722 rename #3 2018-06-26 14:09:39 +02:00
fourtf c9722b9780 rename #2 2018-06-26 13:24:55 +02:00
Renamed from src/widgets/helper/_NotebookButton.cpp (Browse further)