Commit graph

38 commits

Author SHA1 Message Date
Mm2PL
89323ffa1f
Fixed tab completion rarely completing the wrong word. (#4735)
* Fixed tab completion rarely completing the wrong word.

Fixes: #3101

* Use QSignalBlocker instead of janky bool, add comment about hidden logic

* copypasteo
2023-07-31 21:34:53 +00:00
pajlada
c95a65c153
Fix Qt6 building (#4393) 2023-02-19 20:19:18 +01:00
pajlada
a9a985bde1
Only try to extract images if the image uploader is enabled (#4246)
* Only try to extract images if the image uploader is enabled

* Add changelog entry
2022-12-25 12:14:23 +00:00
nerix
457c5725da
fix: Invalid/Dangling completion after updating input (#4072) 2022-10-22 11:42:46 +02:00
Kasia
b232d16b55
Prevent copying in a couple places (#4066) 2022-10-16 14:25:24 +00:00
pajlada
6599009e79
Fix split focusing being broken in certain circumstances when the "Show input when it's empty" setting was disabled (#3838)
Co-authored-by: Kasia <zneix@zneix.eu>
2022-06-26 16:53:09 +00:00
Mm2PL
703f3717e2
Add custom hotkeys. (#2340)
Co-authored-by: LosFarmosCTL <80157503+LosFarmosCTL@users.noreply.github.com>
Co-authored-by: Paweł <zneix@zneix.eu>
Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com>
Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
2021-11-21 17:46:21 +00:00
Paweł
2bd05fd576
Simplify ResizingTextEdit::isFirstWord to avoid invalid QString index warnings (#3285)
Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
2021-10-16 11:00:41 +00:00
Paweł
588ed557f0
Fixed comma appended to username completion when not at the beginning of the message (#3060)
Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
2021-07-24 12:01:50 +02:00
Mm2PL
9fb5ef60d4
Image uploader mime filter uses urls but doesn't check them (#2855)
Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
2021-06-13 14:23:13 +00:00
Leon Richardt
0eed45ae67
Chore: Proper Lambda Formatting (#2167)
Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
2020-11-08 12:02:19 +01:00
Daniel
2eb01af5e7
Prevent default tab completion from overriding colon menu (#2133)
Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
2020-11-01 14:59:43 +01:00
fourtf
5fc495a073 Fixes #1404 2020-09-25 22:59:20 +02:00
Mm2PL
a929053c4b
Dropping images now works on the whole split :) 2020-02-08 16:41:01 +01:00
Mm2PL
553e8f2f7b
Delete useless else block 2020-02-08 15:47:27 +01:00
Mm2PL
a86367f4be
Fix issues pointed out in reviews :)
Fixed PR BabyRage
2020-01-03 14:43:05 +01:00
Mm2PL
77af5d54cf
Change more things.
Things changed:
 - make getImageFileFormat case insensitive
 - use QTextEdit::dragEnterEvent instead of QAbstractScrollArea::dragEnterEvent,
 - Make dragEnterEvent() and dropEvent() overrides.
2019-10-11 17:00:26 +02:00
Mm2PL
bf434f3ac5
Fix the stupid things.
This includes:
 - NuulsUploader.cpp
   - changing upload delay to a #define
   - moving png conversion code to `boost::optional<QByteArray> convertToPng(QImage image)`
   - in uploadImageToNuuls: moving content type definition to a variable, move things around a bit to eliminate an if
   - in upload: adding a comment about `source->hasUrls()` and `source->urls()`, change `uploadQueue.size()` to `!uploadQueue.empty()`
 - ResizingTextEdit.cpp
   - changing #include order
2019-10-11 15:41:33 +02:00
Mm2PL
b55d08df8e
Renamed the pastedImage signal to imagePasted. 2019-09-25 22:39:02 +02:00
Mm2PL
4e9951371f
Applied a bit of foutf's suggestions. Replace uploadQueue.size() with .empty() and swap if/else bodies, move non empty queue check outside of the timer on line 60, move getImageFileFormat to an anonymous namespace, rename pasteFromClipoard to upload(), removed usesless comment, shortened message on line 83, use QMimeData.hasUrls() and QMimeData.urls(), moved GIF format case in upload() more to the top, call original functions in canInsertFromMimeData and dragEnterEvent which are overriden 2019-09-25 22:21:26 +02:00
Mm2PL
65fab779c5
Redo all changes done before breaking the branch. 2019-09-23 19:36:52 +02:00
fourtf
b513caf572 added settings to mention users with , 2019-08-21 01:08:15 +02:00
Leon Richardt
f2b2e3142f Implement simpler fix for emote completion bug
This commit implements a simpler fix for the problem described in #1209.
The setting's signal is connected to a reset of `completionInProgress_`
so that the completion model is updated on the next word already.

This commit also removes the older approach tackling this issue.
2019-08-18 21:37:20 +02:00
Leon Richardt
be5318f275 Fix emote completion bug
This commit fixes a bug that would occur when changing the completion
mode from prefix-only to substring while mid-completion.
In that case, the suggestion list was not updated until the next
completion attempt.

This is fixed by forcing a suggestion list refresh whenever the
setting's checkbox is updated.
2019-08-17 21:31:31 +02:00
Leon Richardt
58d892a8c2 Make Emote Tab Completion Search for Substrings (#1204)
* Make emote tab completion search for substrings

Previously, tab completion only searched for emotes that start
with the current prefix under the cursor. This commit makes tab
completion look for the current prefix as a substring in any position,
not just the start.

Examples:
    * In forsen's channel, tabbing on "pls" will cycle through "DonaldPls", "forsenPls",
    "GachiPls", "nyanPls" and "SourPls".

    * As a forsen subscriber, tabbing on "sen1" will complete to "forsen1".

    * As a pajlada subscriber, tabbing on "shrug" will cycle through
    "pajaShrugL" and "pajaShrugR". (Unless you are in a channel with
    more "shrug" emotes, of course.)

* Add a setting for prefix and substring completion

This commit adds a setting under the "Miscellaneous" section to allow
user to choose whether they want prefix-only or substring emote
completion.

The QCompleter filter mode and `addString` function are now chosen
according to the user's setting.

* Improve description of emote completion setting

Also reintroduce a blank line that went missing.
2019-08-17 17:17:38 +02:00
Rasmus Karlsson
9cb5e3abb3 Fix a bug where tabbing too early would break any future tab completions
Fixes #1107
2019-06-22 13:16:16 +02:00
TranRed
5c350de329 overrides QTextEdit insert methods
fixes Chatterino#635
prepares for future implementation of Chatterino#79

Was a little bit hard to find the right combination for now. Pasting images from clipboard surpasses the check for dragging images in canInsertFromMimeData OMGScoots
2019-06-10 12:20:45 +02:00
fourtf
e259b9e39f added brace wrapping after if and for 2018-10-21 13:43:02 +02:00
fourtf
f6e110b7fb fixed and optimized the autocompletion 2018-08-13 14:04:35 +02:00
fourtf
f71ff08e68 changed to 80 max column 2018-08-06 21:17:03 +02:00
fourtf
280bb4cf8e Renamed private members 2018-07-06 19:24:35 +02:00
Rasmus Karlsson
e757a6504b Run clang-format-all.sh 2018-07-03 15:20:00 +00:00
fourtf
5604ae6a67 removed functions from SettingsManager that shouldn't be there 2018-06-28 19:38:57 +02:00
fourtf
08e552f5f6 ran clang-format on all files 2018-06-26 17:20:03 +02:00
fourtf
2df0566492 removed namespaces 2018-06-26 16:37:59 +02:00
fourtf
15abedd869 moved files into src/common 2018-06-26 15:33:51 +02:00
fourtf
a9bf9cf722 rename #3 2018-06-26 14:09:39 +02:00
fourtf
c9722b9780 rename #2 2018-06-26 13:24:55 +02:00
Renamed from src/widgets/helper/_ResizingTextEdit.cpp (Browse further)