From eaaa52260e84dd7112690d1bcc615cc7a04c0ec7 Mon Sep 17 00:00:00 2001
From: fourtf <tf.four@gmail.com>
Date: Mon, 2 Sep 2019 19:00:17 +0200
Subject: [PATCH] smol fixes

---
 resources/buttons/search.png               | Bin 0 -> 2284 bytes
 src/widgets/settingspages/GeneralPage.cpp  |  22 +++++++++++++++++++--
 src/widgets/settingspages/SettingsPage.cpp |   2 +-
 3 files changed, 21 insertions(+), 3 deletions(-)
 create mode 100644 resources/buttons/search.png

diff --git a/resources/buttons/search.png b/resources/buttons/search.png
new file mode 100644
index 0000000000000000000000000000000000000000..8671ce64423b8aa2344e4e6c2a6557937d2020f6
GIT binary patch
literal 2284
zcmV<I2ov{-P)<h;3K|Lk000e1NJLTq003wJ003(U1^@s6n~28`00001b5ch_0Itp)
z=>Px#1ZP1_K>z@;j|==^1poj532;bRa{vGi!T<mc!T}X1N`L?W2!TmNK~#8N?VU~N
zR8<^?r*PrIg$oxhTo@D>7#I`;859&17#Y|iGHOv!P#{#`!pN|Ys32%jVBo^SqQbz!
zpu(WS7D0i5L4id<ErNuCf&zP=xpQTh&Ykl+ch0%@+>Zxd=Kcr%ckVgwobPjfbJ6+p
z=O>x5QQ9_pg>}+~;&Sqv^k;E7`BnOQ_S#$8HV6~0m#&qrlD0_er4Y_Z-%4LfpG%)e
zy)mr~gD4&MO1DTDk^&6-KzdX9f;YNKQwC8|?w9VCQkhc4_tNXqD^ll5R%(ORN_(Y8
zCEAiU`CEEkdO@OE>;$O{S|i;j9gxb#J{KrOPf4#z|MEu8q%dfQ^qkamRTc_W-{aD|
z)4wt$ra@b!mn3>+U4mZUBhok1zcM41L6n-KQrqoJT^L*4CA~NOD<fhUL??i@hIS_w
zv<*K?KS;D0T*D@bHf{6lI_77>6VlVgWge_z5IwX*((dVBtHD_1eTnt}LzpqJzzhRM
zQG#!lwo9w>hV+0`&RDccU4!@*ACs<`{uK^gUh4jLBnFga30W1M3$t#QZj|^E)qyFb
z+oV{}RUZrr)K=*ysSbZh2c`9r>)tWNXY7~w%sTucZI@j4ZcNTMmuRC@$DDtp!xI1R
zx^GJHnTI5vArws7EV=I6h@5X$XsvWg3gwuzMRMJ<N%0IkODLzMb&~6z$>n^rLPw+!
z{*ZP`u6wnqT@ue0!g0xUujF#R>Cj#&gtHQDmFr$PXq&_{hHyY~-7Be_Z!Tzu6jFbm
zlr~7Nd*vkBCZ08f-ID8G$>i&1GktSPvd$1NrO&iU_LGn^80fw%u@qu~;lXthi-V2e
zGw7sbom<14hl<P2!GPOp5@Vz*i_7#ZGl&7-@#4}8gU*|zu9TcbC`lhm)-U5d(rd+K
zTB;1<flo`8B?IQmu9mFRGr7Vn1l2k7d_GvJxLiv9g}iw7x(JJH7IT=dVoIdz<^Xem
zcSx2wxJ#vni_5gQN)Yo`XC=!@C<)4X!K((lq_>L8rC=zfDCzRKs|2xpU@-?{`eqKi
zEm_h<9_=YE)3I2B_|WepU$>gN_X>&aO?`ywoi^CF-b8hHnM7$y!eR-ct7#eY(1Yo#
zIY8Phy)^R5+C8tuVhK7U`8o#-)-I8feQPp-+Jv^)x2A-dv_(mnFG1}1wDjCwl=^NC
zkVew#gFGYek}z)&+i`tRdY&yV2LWj%%|0x7SBrUr*emUW8H3L3%8USMCCxr8c~^_l
zAnIF7^~N58p<zigd1sk{2&Od1ItRrDkD*~rbCM04r9qs}@xj)p_IJ574{5d>VPV@>
zbV`FbJmrIZYeU77c1sfxOlgqi=6#&jv0~X0oXj9P2$o}qLm2y1VX4{~&_?elV31{y
z#oSvTmK5qj+AV88(MwTTf_x0IbFhdd4=i~ZMA-)UVAXW!w2}uHWSPAla{E(a$ph=|
zCo>pS28me4SjE}$z>=3iSgW{^mcSrO?~FrIL&uT_(R;cWWZA_My?4?<EO`+9RGzhp
zOEOd2F<Qw346^i2#wyO12hn@G7{p#<AM9?4-b3jSq}{i}2cmDJDNB%Lm2}AMkfrpn
zG#-60Ted+K=XcIthX@A=d?eY1RvKhE?~-Iesv}s^p41>B75X4Z#1N}F(rgKk@$u|6
zDy2b|ohx7|>V3nS=8tBtQ7H|gqhKkbMDQ3ImNau-D9LPhX%JX;uMl1(`iyPHu+mJL
zeI$#LHE$3BSbeap`&e-~2smD1iT7j4yIL%6p6BQZr^l9&{K!Qn&^fSdo~L>vKawzC
zf`I6_KB(fJEG~NuG4L#<$C78YaUI~Yd~4W1!I2BTJ$;1DAC?1L$&cbJmLNWe(8WG@
za018nm4lLH?k)LIoW&9Z^jtW|Wf_zX`4BPlmz18y4-xZ$&lHzlj!1-y=?m-;JX~CQ
zA@+7sbHG)CfZ|Ol^7ZIosDUgvL~S|TwGyrp1atxj`fY&(Q6*UF>|Ej52`g<~HKp_<
zHwUT=0@@bq935w42x{I{h<If^-@^iDBXN3QnL$8kG3!Q%2PG2PrIN(6hD5re)DW_{
zF?<FQE}w|(RxpXEQC(Obr_JG6L*g7@PGhm+rqD?+XrB~9A46giPTF;^q;kGlp`%g=
zeF`djLRura?w3@~H!DPF;;*Dox*nGKjMRy+%xIHDu<ua18rb}t)asYZ*GX7}9sYMp
zq4Q7lmIxBaL@e`Mp}+K42R>uJ#AnhGsMEXrQEK&MN7YP%4+eC^Gp#$#LwA)iR<1v;
zG0$hxty1)T*B0s;1gr}&`i`-YB&VOJanYJds~A+m!q&dxG8#-ZQL32d!?3c1VFsmy
z63lgzgW^_9ieV7&BTtOTV^k?Q)3`~YorEfwo4P@=Y{buvkV#Lf&=XQ)JDXw|1hgYW
zWGCo%7nZ_#MxK>Lw~%eS&6-3Nmq3iV_egcdOsV-@;@S8;r1E(gD={Dq;ZrI305(<|
zR0U%Z_Lk-HQ_<`pAc~@EC6vwwzf}<uEhKrHl-i&Y63<{U_a9r&&ZMRcnum3NVtf)t
zGL>1F!ggGCd|G0?&6AZ$Z5T8U;~7>m8Dx?nD733i)kPzZI0C{cgH<=OXJb;^2D!jA
zGKNe7+OBc|kQs(D1E{VrCCRA*k%dV)8k7^Qn-p^#)JG_#48U6(CyfUAY1O3BARDcj
zG#X^56_ZAT!f4#2(V%b|HEA@c9*vna8dRS~Od1VZjpQbc2CYs~lSYH$kj$jfpm-!P
zX*4J<(M=i+iceINMuXB2&7{$wbVM;}G$<`~O}Y?BV>Bo|p(e2sdm)g>Xizg)O~M?O
z%UL#`G8)tzK9l}u4vYphOO;7Zb6_;6c@|BoG-ooIO#TDeg?+-rP)TI~0000<MNUMn
GLSTaY*(<^T

literal 0
HcmV?d00001

diff --git a/src/widgets/settingspages/GeneralPage.cpp b/src/widgets/settingspages/GeneralPage.cpp
index 5c3b79e72..f86b984e7 100644
--- a/src/widgets/settingspages/GeneralPage.cpp
+++ b/src/widgets/settingspages/GeneralPage.cpp
@@ -144,12 +144,28 @@ bool SettingsLayout::filterElements(const QString &query)
 
     for (auto &&group : this->groups_)
     {
+        // if a description in a group matches `query` then show the entire group
+        bool descriptionMatches{};
+        for (auto &&widget : group.widgets)
+        {
+            if (auto x = dynamic_cast<DescriptionLabel *>(widget.element); x)
+            {
+                if (x->text().contains(query, Qt::CaseInsensitive))
+                {
+                    descriptionMatches = true;
+                    break;
+                }
+            }
+        }
+
         // if group name matches then all should be visible
-        if (group.name.contains(query, Qt::CaseInsensitive))
+        if (group.name.contains(query, Qt::CaseInsensitive) ||
+            descriptionMatches)
         {
             for (auto &&widget : group.widgets)
                 widget.element->show();
             group.title->show();
+            any = true;
         }
         // check if any match
         else
@@ -173,6 +189,7 @@ bool SettingsLayout::filterElements(const QString &query)
             }
 
             group.title->setVisible(groupAny);
+            any |= groupAny;
         }
     }
 
@@ -207,7 +224,8 @@ bool GeneralPage::filterElements(const QString &query)
 {
     if (this->settingsLayout_)
         return this->settingsLayout_->filterElements(query) ||
-               this->name_.contains(query) || query.isEmpty();
+               this->name_.contains(query, Qt::CaseInsensitive) ||
+               query.isEmpty();
     else
         return false;
 }
diff --git a/src/widgets/settingspages/SettingsPage.cpp b/src/widgets/settingspages/SettingsPage.cpp
index 0d7d8d129..5a20fbf70 100644
--- a/src/widgets/settingspages/SettingsPage.cpp
+++ b/src/widgets/settingspages/SettingsPage.cpp
@@ -57,7 +57,7 @@ SettingsPage::SettingsPage(const QString &name, const QString &iconResource)
 bool SettingsPage::filterElements(const QString &query)
 {
     return filterItemsRec(this, query) || query.isEmpty() ||
-           this->name_.contains(query);
+           this->name_.contains(query, Qt::CaseInsensitive);
 }
 
 const QString &SettingsPage::getName()