noury/mirror-chatterino2
1
0
Fork 0
mirror of https://github.com/Chatterino/chatterino2.git synced 2024-11-13 19:49:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

Clean up compiler warnings (#2027)

Browse source 
Fix the following compiler warning
../src/common/NetworkResult.hpp: In constructor ‘chatterino::NetworkResult::NetworkResult(const QByteArray&, int)’:
../src/common/NetworkResult.hpp:28:16: warning: ‘chatterino::NetworkResult::data_’ will be initialized after [-Wreorder]
   28 |     QByteArray data_;
      |                ^~~~~
../src/common/NetworkResult.hpp:27:9: warning:   ‘int chatterino::NetworkResult::status_’ [-Wreorder]
   27 |     int status_;
      |         ^~~~~~~
../src/common/NetworkResult.cpp:9:1: warning:   when initialized here [-Wreorder]
    9 | NetworkResult::NetworkResult(const QByteArray &data, int status)

* Clang compiler warnings

Fixes every instance of the following error:

In file included from ../src/widgets/settingspages/CommandPage.cpp:12:
In file included from ../src/controllers/commands/CommandModel.hpp:5:
../src/common/SignalVectorModel.hpp:242:10: warning: 'moveRows' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    bool moveRows(const QModelIndex &sourceParent, int sourceRow, int count,
         ^
../src/controllers/commands/CommandModel.hpp:12:29: note: in instantiation of template class 'chatterino::SignalVectorModel<chatterino::Command>' requested here
class CommandModel : public SignalVectorModel<Command>
This commit is contained in:
Vilgot Fredenberg 2020-10-04 12:47:23 +02:00 committed by GitHub
parent 58a6983796
commit de04ff82a7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/common/NetworkResult.hpp
View file

@ -24,8 +24,8 @@ public:
static constexpr int timedoutStatus = -2;
private:
int status_;
QByteArray data_;
int status_;
};
} // namespace chatterino

5
src/common/SignalVectorModel.hpp
View file

@ -240,7 +240,8 @@ public:
}
bool moveRows(const QModelIndex &sourceParent, int sourceRow, int count,
const QModelIndex &destinationParent, int destinationChild)
const QModelIndex &destinationParent,
int destinationChild) override
{
if (count != 1)
{
@ -287,7 +288,7 @@ public:
return {"chatterino_row_id"};
}
QMimeData *mimeData(const QModelIndexList &list) const
QMimeData *mimeData(const QModelIndexList &list) const override
{
if (list.length() == 1)
{

2
src/providers/twitch/TwitchMessageBuilder.hpp
View file

@ -66,7 +66,7 @@ private:
void appendTwitchEmote(const QString &emote,
std::vector<TwitchEmoteOccurence> &vec,
std::vector<int> &correctPositions);
Outcome tryAppendEmote(const EmoteName &name);
Outcome tryAppendEmote(const EmoteName &name) override;
void addWords(const QStringList &words,
const std::vector<TwitchEmoteOccurence> &twitchEmotes);

4
src/widgets/dialogs/switcher/NewTabItem.hpp
View file

@ -20,8 +20,8 @@ public:
*/
virtual void action() override;
virtual void paint(QPainter *painter, const QRect &rect) const;
virtual QSize sizeHint(const QRect &rect) const;
virtual void paint(QPainter *painter, const QRect &rect) const override;
virtual QSize sizeHint(const QRect &rect) const override;
private:
static constexpr const char *TEXT_FORMAT = "Open channel \"%1\" in new tab";

4
src/widgets/dialogs/switcher/SwitchSplitItem.hpp
View file

@ -18,8 +18,8 @@ public:
virtual void action() override;
virtual void paint(QPainter *painter, const QRect &rect) const;
virtual QSize sizeHint(const QRect &rect) const;
virtual void paint(QPainter *painter, const QRect &rect) const override;
virtual QSize sizeHint(const QRect &rect) const override;
private:
Split *split_{};