From c26fb01df50b799a607d76ee1dcd3fd62f083b34 Mon Sep 17 00:00:00 2001 From: pajlada Date: Sat, 1 Jan 2022 14:15:52 +0100 Subject: [PATCH] Fixed crash that could occur when the user closes the Settings dialog (#3444) --- CHANGELOG.md | 1 + src/widgets/helper/ChannelView.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 60d4fbad0..35754983c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -75,6 +75,7 @@ - Bugfix: Fixed zero-width emotes sometimes wrapping lines incorrectly. (#3389) - Bugfix: Fixed using special chars in Windows username breaking the storage of custom commands (#3397) - Bugfix: Fixed character counter changing fonts after going over the limit. (#3422) +- Bugfix: Fixed crash that could occur if the user opens/closes ChannelViews (e.g. EmotePopup, or Splits) then modifies the showLastMessageIndicator setting. (#3444) - Dev: Add GitHub action to test builds without precompiled headers enabled. (#3327) - Dev: Renamed CMake's build option `USE_SYSTEM_QT5KEYCHAIN` to `USE_SYSTEM_QTKEYCHAIN`. (#3103) - Dev: Add benchmarks that can be compiled with the `BUILD_BENCHMARKS` CMake flag. Off by default. (#3038) diff --git a/src/widgets/helper/ChannelView.cpp b/src/widgets/helper/ChannelView.cpp index 1a51f1184..0f450cb14 100644 --- a/src/widgets/helper/ChannelView.cpp +++ b/src/widgets/helper/ChannelView.cpp @@ -194,7 +194,7 @@ void ChannelView::initializeSignals() [this](auto, auto) { this->update(); }, - this); + this->signalHolder_); this->signalHolder_.managedConnect(getApp()->windows->gifRepaintRequested, [&] {