From bd4f6f3a1f0320eff82f04148b4c1dd1ad58b069 Mon Sep 17 00:00:00 2001 From: nerix Date: Sun, 21 May 2023 19:42:40 +0200 Subject: [PATCH] Configure CMake for `clang-tidy` separately (#4648) Co-authored-by: Rasmus Karlsson --- .github/workflows/build.yml | 17 ++++++++++++++++- CHANGELOG.md | 1 + 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 27bb7e51e..f11e9fcbf 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -278,10 +278,25 @@ jobs: if: matrix.clang-tidy-review && github.event_name == 'pull_request' uses: ZedThree/clang-tidy-review@v0.13.0 with: - build_dir: build + build_dir: build-clang-tidy config_file: ".clang-tidy" split_workflow: true exclude: "tests/*,lib/*" + cmake_command: >- + cmake -S. -Bbuild-clang-tidy + -DCMAKE_BUILD_TYPE=Release + -DPAJLADA_SETTINGS_USE_BOOST_FILESYSTEM=On + -DUSE_PRECOMPILED_HEADERS=OFF + -DCMAKE_EXPORT_COMPILE_COMMANDS=On + -DCHATTERINO_LTO=Off + -DCHATTERINO_PLUGINS=On + -DBUILD_WITH_QT6=Off + apt_packages: >- + qttools5-dev, qt5-image-formats-plugins, libqt5svg5-dev, + libsecret-1-dev, + libboost-dev, libboost-system-dev, libboost-filesystem-dev, + libssl-dev, + rapidjson-dev - name: clang-tidy-review upload if: matrix.clang-tidy-review && github.event_name == 'pull_request' diff --git a/CHANGELOG.md b/CHANGELOG.md index bd82de959..be24b4f96 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ - Dev: Added command to set Qt's logging filter/rules at runtime (`/c2-set-logging-rules`). (#4637) - Dev: Added the ability to see & load custom themes from the Themes directory. No stable promises are made of this feature, changes might be made that breaks custom themes without notice. (#4570) - Dev: Added test cases for emote and tab completion. (#4644) +- Dev: Fixed `clang-tidy-review` action not picking up dependencies. (#4648) ## 2.4.4