Fix tab direction change crash (#4248)

* Fix tab direction change crash

* changelog

* Update CHANGELOG.md

Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>

Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
This commit is contained in:
kornes 2022-12-19 17:19:09 +00:00 committed by GitHub
parent 69a73e3291
commit bc5a03af26
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions

View file

@ -13,6 +13,7 @@
- Bugfix: Fixed message input showing as red after removing a message that was more than 500 characters. (#4204) - Bugfix: Fixed message input showing as red after removing a message that was more than 500 characters. (#4204)
- Bugfix: Fixed unnecessary saving of windows layout. (#4201) - Bugfix: Fixed unnecessary saving of windows layout. (#4201)
- Bugfix: Fixed Reply window missing selection clear behaviour between chat and input box. (#4218) - Bugfix: Fixed Reply window missing selection clear behaviour between chat and input box. (#4218)
- Bugfix: Fixed crash that could occur when changing Tab layout and utilizing multiple windows. (#4248)
- Dev: Ignore `WM_SHOWWINDOW` hide events, causing fewer attempted rescales. (#4198) - Dev: Ignore `WM_SHOWWINDOW` hide events, causing fewer attempted rescales. (#4198)
## 2.4.0 ## 2.4.0

View file

@ -80,9 +80,11 @@ Window::Window(WindowType type, QWidget *parent)
}); });
if (type == WindowType::Main || type == WindowType::Popup) if (type == WindowType::Main || type == WindowType::Popup)
{ {
getSettings()->tabDirection.connect([this](int val) { getSettings()->tabDirection.connect(
[this](int val) {
this->notebook_->setTabLocation(NotebookTabLocation(val)); this->notebook_->setTabLocation(NotebookTabLocation(val));
}); },
this->signalHolder_);
} }
} }