From 94e266ac82eb3d2d72b4b5eaf1b840b655b1e810 Mon Sep 17 00:00:00 2001 From: nerix Date: Sat, 5 Oct 2024 13:09:23 +0200 Subject: [PATCH] fix: avoid holes when moving tabs (#5612) --- CHANGELOG.md | 2 +- src/widgets/helper/NotebookTab.cpp | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d92b37954..3e628a5fb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,7 +31,7 @@ - Minor: Removed experimental IRC support. (#5547) - Minor: Moderators can now see which mods start and cancel raids. (#5563) - Minor: The emote popup now reloads when Twitch emotes are reloaded. (#5580) -- Bugfix: Fixed tab move animation occasionally failing to start after closing a tab. (#5426) +- Bugfix: Fixed tab move animation occasionally failing to start after closing a tab. (#5426, #5612) - Bugfix: If a network request errors with 200 OK, Qt's error code is now reported instead of the HTTP status. (#5378) - Bugfix: Fixed restricted users usernames not being clickable. (#5405) - Bugfix: Fixed a crash that could occur when logging was enabled in IRC servers that were removed. (#5419) diff --git a/src/widgets/helper/NotebookTab.cpp b/src/widgets/helper/NotebookTab.cpp index ea893f6ea..be2b371a3 100644 --- a/src/widgets/helper/NotebookTab.cpp +++ b/src/widgets/helper/NotebookTab.cpp @@ -412,11 +412,6 @@ void NotebookTab::moveAnimated(QPoint targetPos, bool animated) { this->positionAnimationDesiredPoint_ = targetPos; - if (this->pos() == targetPos) - { - return; - } - if (!animated || !this->notebook_->isVisible()) { this->move(targetPos);