From 63f363e5a98eb2c6ff76d9e0e813581a6fed716a Mon Sep 17 00:00:00 2001 From: Ilya Zlobintsev Date: Tue, 12 Nov 2024 16:41:12 +0200 Subject: [PATCH] Deduplicate emotes by name in smart tab emote completion strategy (#5705) --- CHANGELOG.md | 1 + src/controllers/completion/TabCompletionModel.cpp | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8ca06e5d1..f84cf3360 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -42,6 +42,7 @@ - Minor: Tabs unhighlight when their content is read in other tabs. (#5649) - Minor: Made usernames in bits and sub messages clickable. (#5686) - Minor: Mentions of FrankerFaceZ and BetterTTV in settings are standardized as such. (#5698) +- Minor: Emote names are no longer duplicated when using smarter emote completion. (#5705) - Bugfix: Fixed tab move animation occasionally failing to start after closing a tab. (#5426, #5612) - Bugfix: If a network request errors with 200 OK, Qt's error code is now reported instead of the HTTP status. (#5378) - Bugfix: Fixed restricted users usernames not being clickable. (#5405) diff --git a/src/controllers/completion/TabCompletionModel.cpp b/src/controllers/completion/TabCompletionModel.cpp index 585fe3a08..829fe8e82 100644 --- a/src/controllers/completion/TabCompletionModel.cpp +++ b/src/controllers/completion/TabCompletionModel.cpp @@ -43,11 +43,15 @@ void TabCompletionModel::updateResults(const QString &query, query, fullTextContent, cursorPosition, isFirstWord); if (done) { + auto uniqueResults = std::unique(results.begin(), results.end()); + results.erase(uniqueResults, results.end()); this->setStringList(results); return; } #endif this->source_->addToStringList(results, 0, isFirstWord); + auto uniqueResults = std::unique(results.begin(), results.end()); + results.erase(uniqueResults, results.end()); this->setStringList(results); } }