noury/mirror-chatterino2
1
0
Fork 0
mirror of https://github.com/Chatterino/chatterino2.git synced 2024-11-21 22:24:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix various small warnings (#4296)

Browse source 
* Fix `inconsistent-missing-override` warnings

* Fix `final-dtor-non-final-class` warnings

* Fix `ambiguous-reversed-operator` warnings
This commit is contained in:
pajlada 2023-01-08 14:32:52 +01:00 committed by GitHub
parent 1faa973402
commit 5ad8ca791c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGELOG.md
View file

@ -30,6 +30,9 @@
- Dev: Removed unused operators in `Image` (#4267) - Dev: Removed unused operators in `Image` (#4267)
- Dev: Removed usage of deprecated `QDesktopWidget` (#4287) - Dev: Removed usage of deprecated `QDesktopWidget` (#4287)
- Dev: Bump Cirrus CI FreeBSD image from 12.1 to 13.1. (#4295) - Dev: Bump Cirrus CI FreeBSD image from 12.1 to 13.1. (#4295)
- Dev: Fixed `inconsistent-missing-override` warnings. (#4296)
- Dev: Fixed `final-dtor-non-final-class` warnings. (#4296)
- Dev: Fixed `ambiguous-reversed-operator` warnings. (#4296)
## 2.4.0 ## 2.4.0

4
src/CMakeLists.txt
View file

@ -846,6 +846,10 @@ else ()
target_compile_options(${LIBRARY_PROJECT} PUBLIC target_compile_options(${LIBRARY_PROJECT} PUBLIC
-Wno-unused-local-typedef -Wno-unused-local-typedef
-Wno-unused-private-field -Wno-unused-private-field
-Werror=inconsistent-missing-override
-Werror=final-dtor-non-final-class
-Werror=ambiguous-reversed-operator
) )
else () else ()
target_compile_options(${LIBRARY_PROJECT} PUBLIC target_compile_options(${LIBRARY_PROJECT} PUBLIC

4
src/common/FlagsEnum.hpp
View file

@ -27,12 +27,12 @@ public:
} }
} }
bool operator==(const FlagsEnum<T> &other) bool operator==(const FlagsEnum<T> &other) const
{ {
return this->value_ == other.value_; return this->value_ == other.value_;
} }
bool operator!=(const FlagsEnum<T> &other) bool operator!=(const FlagsEnum<T> &other) const
{ {
return this->value_ != other.value_; return this->value_ != other.value_;
} }

4
src/widgets/dialogs/ColorPickerDialog.hpp
View file

@ -53,8 +53,8 @@ public:
pajlada::Signals::Signal<QColor> closed; pajlada::Signals::Signal<QColor> closed;
protected: protected:
void closeEvent(QCloseEvent *); void closeEvent(QCloseEvent *) override;
void themeChangedEvent(); void themeChangedEvent() override;
private: private:
struct { struct {

2
src/widgets/dialogs/EditHotkeyDialog.hpp
View file

@ -14,7 +14,7 @@ namespace chatterino {
class Hotkey; class Hotkey;
class EditHotkeyDialog : public QDialog class EditHotkeyDialog final : public QDialog
{ {
Q_OBJECT Q_OBJECT