Fix the split "Search" menu action not opening the correct search window (#4305)

* Fix split menu "Search" action

It now opens a split-specific search instead of a global one

* Add changelog entry

CHANGELOG.md

@@ -23,6 +23,7 @@
 - Bugfix: Fixed crash that could occur when closing down a split at the wrong time. (#4277)
 - Bugfix: Fixed crash that could occur when closing down the last of a channel when reloading emotes. (#4278)
 - Bugfix: Fixed scrollbar highlight colors when changing message history limit. (#4288)
+- Bugfix: Fixed the split "Search" menu action not opening the correct search window. (#4305)
 - Bugfix: Fixed an issue on Windows when opening links in incognito mode that contained forward slashes in hash (#4307)
 - Dev: Remove protocol from QApplication's Organization Domain (so changed from `https://www.chatterino.com` to `chatterino.com`). (#4256)
 - Dev: Ignore `WM_SHOWWINDOW` hide events, causing fewer attempted rescales. (#4198)

src/widgets/splits/SplitHeader.cpp

@@ -373,7 +373,11 @@ std::unique_ptr<QMenu> SplitHeader::createMainMenu()
     menu->addAction(
         "Popup", this->split_, &Split::popup,
         h->getDisplaySequence(HotkeyCategory::Window, "popup", {{"split"}}));
-    menu->addAction("Search", this->split_, &Split::showSearch,
+    menu->addAction(
+        "Search", this->split_,
+        [this] {
+            this->split_->showSearch(true);
+        },
         h->getDisplaySequence(HotkeyCategory::Split, "showSearch"));
     menu->addAction(
         "Set filters", this->split_, &Split::setFiltersDialog,