Added missing window titles to all popups (#2120)

src/util/StreamLink.cpp

@@ -62,6 +62,7 @@ namespace {
     void showStreamlinkNotFoundError()
     {
         static QErrorMessage *msg = new QErrorMessage;
+        msg->setWindowTitle("Chatterino - streamlink not found");
 
         if (getSettings()->streamlinkUseCustomPath)
         {

src/widgets/dialogs/ColorPickerDialog.cpp

@@ -264,6 +264,7 @@ void ColorPickerDialog::initDefaultColors(LayoutCreator<QWidget> &creator)
 
 void ColorPickerDialog::initColorPicker(LayoutCreator<QWidget> &creator)
 {
+    this->setWindowTitle("Chatterino - color picker");
     auto cpPanel = creator.setLayoutType<QHBoxLayout>();
 
     /*

src/widgets/dialogs/LoginDialog.cpp

@@ -53,6 +53,8 @@ namespace {
                            SWP_NOMOVE | SWP_NOSIZE | SWP_SHOWWINDOW);
 
 #endif
+            messageBox.setWindowTitle(
+                "Chatterino - invalid account credentials");
             messageBox.setIcon(QMessageBox::Critical);
             messageBox.setText(errors.join("<br />"));
             messageBox.setStandardButtons(QMessageBox::Ok);
@@ -89,6 +91,8 @@ BasicLoginWidget::BasicLoginWidget()
 
     this->ui_.loginButton.setText("Log in (Opens in browser)");
     this->ui_.pasteCodeButton.setText("Paste login info");
+    this->ui_.unableToOpenBrowserHelper.setWindowTitle(
+        "Chatterino - unable to open in browser");
     this->ui_.unableToOpenBrowserHelper.setWordWrap(true);
     this->ui_.unableToOpenBrowserHelper.hide();
     this->ui_.unableToOpenBrowserHelper.setText(
@@ -243,12 +247,12 @@ LoginWidget::LoginWidget()
                    SWP_NOMOVE | SWP_NOSIZE | SWP_SHOWWINDOW);
 #endif
 
-    this->setLayout(&this->ui_.mainLayout);
+    this->setWindowTitle("Chatterino - add new account");
 
+    this->setLayout(&this->ui_.mainLayout);
     this->ui_.mainLayout.addWidget(&this->ui_.tabWidget);
 
     this->ui_.tabWidget.addTab(&this->ui_.basic, "Basic");
-
     this->ui_.tabWidget.addTab(&this->ui_.advanced, "Advanced");
 
     this->ui_.buttonBox.setStandardButtons(QDialogButtonBox::Close);

src/widgets/dialogs/QualityPopup.cpp

@@ -31,6 +31,7 @@ void QualityPopup::showDialog(const QString &channelName, QStringList options)
 {
     QualityPopup *instance = new QualityPopup(channelName, options);
 
+    instance->window()->setWindowTitle("Chatterino - select stream quality");
     instance->setAttribute(Qt::WA_DeleteOnClose, true);
 
     instance->show();

src/widgets/settingspages/AboutPage.cpp

@@ -230,9 +230,11 @@ void AboutPage::addLicense(QFormLayout *form, const QString &name,
     auto *a = new QLabel("<a href=\"" + website + "\">" + name + "</a>");
     a->setOpenExternalLinks(true);
     auto *b = new QLabel("<a href=\"" + licenseLink + "\">show license</a>");
-    QObject::connect(b, &QLabel::linkActivated, [licenseLink] {
+    QObject::connect(b, &QLabel::linkActivated, [licenseLink, name] {
         auto *edit = new QTextEdit;
 
+        edit->setWindowTitle(
+            QString("Chatterino - showing %1's license").arg(name));
         QFile file(licenseLink);
         file.open(QIODevice::ReadOnly);
         edit->setText(file.readAll());

src/widgets/splits/Split.cpp

@@ -120,6 +120,7 @@ Split::Split(QWidget *parent)
     createShortcut(this, "F10", [] {
         auto *popup = new DebugPopup;
         popup->setAttribute(Qt::WA_DeleteOnClose);
+        popup->setWindowTitle("Chatterino - Debug popup");
         popup->show();
     });