noury/mirror-chatterino2
1
0
Fork 0
mirror of https://github.com/Chatterino/chatterino2.git synced 2024-11-21 22:24:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Move dangerous stdlib logic to PluginMeta

Browse source
This commit is contained in:
Mm2PL 2023-02-01 17:30:32 +01:00
parent cf9e5ed66c
commit 13d2ff870f
No known key found for this signature in database
GPG key ID: 94AC9B80EFA15ED9
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/controllers/plugins/PluginController.hpp
View file

@ -66,6 +66,13 @@ struct PluginMeta {
this->libraryPermissions.insert(t.toString()); this->libraryPermissions.insert(t.toString());
} }
} }
bool hasDangerousLibraries()
{
const auto *perms = &this->libraryPermissions;
return perms->contains("io") || perms->contains("package") ||
perms->contains("os");
}
}; };
class Plugin class Plugin

6
src/widgets/settingspages/PluginsPage.cpp
View file

@ -93,19 +93,15 @@ void PluginsPage::rebuildContent()
pl->addRow("License", new QLabel(plugin->meta.license)); pl->addRow("License", new QLabel(plugin->meta.license));
QString libString; QString libString;
bool hasDangerous = false;
for (const auto &library : plugin->meta.libraryPermissions) for (const auto &library : plugin->meta.libraryPermissions)
{ {
if (!libString.isEmpty()) if (!libString.isEmpty())
{ {
libString += ", "; libString += ", ";
} }
if (library == "os" || library == "io" || library == "package")
{
hasDangerous = true;
}
libString += library; libString += library;
} }
bool hasDangerous = plugin->meta.hasDangerousLibraries();
if (hasDangerous) if (hasDangerous)
{ {
libString += "\nDetected potentially dangerous libraries used, be " libString += "\nDetected potentially dangerous libraries used, be "