From 116e82dcc508fb3b8a7e7f3c27953898b00e31fb Mon Sep 17 00:00:00 2001
From: nealxm <88364802+nealxm@users.noreply.github.com>
Date: Tue, 9 Apr 2024 16:33:58 -0700
Subject: [PATCH] fix: the version string not showing up as expected in Finder
on macOS (#5311)
---
CHANGELOG.md | 1 +
cmake/MacOSXBundleInfo.plist.in | 2 --
src/CMakeLists.txt | 1 -
3 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 10c71cf5f..990cca03d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,7 @@
## Unversioned
- Bugfix: Fixed split tooltip getting stuck in some cases. (#5309)
+- Bugfix: Fixed the version string not showing up as expected in Finder on macOS. (#5311)
## 2.5.0-beta.1
diff --git a/cmake/MacOSXBundleInfo.plist.in b/cmake/MacOSXBundleInfo.plist.in
index ae08eb0d9..9077068db 100644
--- a/cmake/MacOSXBundleInfo.plist.in
+++ b/cmake/MacOSXBundleInfo.plist.in
@@ -6,8 +6,6 @@
English
CFBundleExecutable
${MACOSX_BUNDLE_EXECUTABLE_NAME}
- CFBundleGetInfoString
- ${MACOSX_BUNDLE_INFO_STRING}
CFBundleIconFile
${MACOSX_BUNDLE_ICON_FILE}
CFBundleIdentifier
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index fa545a644..eb64bcf31 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -986,7 +986,6 @@ if (APPLE AND BUILD_APP)
PROPERTIES
MACOSX_BUNDLE_BUNDLE_NAME "Chatterino"
MACOSX_BUNDLE_GUI_IDENTIFIER "com.chatterino"
- MACOSX_BUNDLE_INFO_STRING "Chat client for Twitch"
MACOSX_BUNDLE_LONG_VERSION_STRING "${PROJECT_VERSION}"
MACOSX_BUNDLE_SHORT_VERSION_STRING "${PROJECT_VERSION}"
MACOSX_BUNDLE_BUNDLE_VERSION "${PROJECT_VERSION}"