From 0dd545fa15a88686041e196fcae5ebcecd2b0c77 Mon Sep 17 00:00:00 2001
From: Leon Richardt <leon.richardt@gmail.com>
Date: Fri, 2 Jul 2021 21:53:24 +0200
Subject: [PATCH] fix: provide better UX for HTML color picker edit (#2942)

---
 CHANGELOG.md                              |  1 +
 src/widgets/dialogs/ColorPickerDialog.cpp | 11 +++++------
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9d793f31b..e7b7da54f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - Minor: Channel name in `<channel> has gone offline. Exiting host mode.` messages is now clickable. (#2922)
 - Minor: Added `/openurl` command. Usage: `/openurl <URL>`. Opens the provided URL in the browser. (#2461, #2926)
 - Bugfix: Fixed large timeout durations in moderation buttons overlapping with usernames or other buttons. (#2865, #2921)
+- Bugfix: Fix bad behavior of the HTML color picker edit when user input is being entered. (#2942)
 
 ## 2.3.3
 
diff --git a/src/widgets/dialogs/ColorPickerDialog.cpp b/src/widgets/dialogs/ColorPickerDialog.cpp
index 5f3c72626..867fe06e1 100644
--- a/src/widgets/dialogs/ColorPickerDialog.cpp
+++ b/src/widgets/dialogs/ColorPickerDialog.cpp
@@ -365,12 +365,11 @@ void ColorPickerDialog::initHtmlColor(LayoutCreator<QWidget> &creator)
     html->addWidget(htmlLabel, 0, 0);
     html->addWidget(htmlEdit, 0, 1);
 
-    QObject::connect(htmlEdit, &QLineEdit::textEdited,
-                     [=](const QString &text) {
-                         QColor col(text);
-                         if (col.isValid())
-                             this->selectColor(col, false);
-                     });
+    QObject::connect(htmlEdit, &QLineEdit::editingFinished, [this] {
+        const QColor col(this->ui_.picker.htmlEdit->text());
+        if (col.isValid())
+            this->selectColor(col, false);
+    });
 }
 
 }  // namespace chatterino