From 51046034e4ba8f217e05cff42a003c57ff3ca3b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lera=20Elvo=C3=A9?= Date: Thu, 25 Jan 2024 07:36:21 +0000 Subject: [PATCH] fix crashes in add node menu with empty search results (#58) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fixes #54 Reviewed-on: https://codeberg.org/StreamGraph/StreamGraph/pulls/58 Co-authored-by: Lera Elvoé Co-committed-by: Lera Elvoé --- graph_node_renderer/add_node_menu.gd | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/graph_node_renderer/add_node_menu.gd b/graph_node_renderer/add_node_menu.gd index cd3e20f..3b8da83 100644 --- a/graph_node_renderer/add_node_menu.gd +++ b/graph_node_renderer/add_node_menu.gd @@ -86,6 +86,9 @@ func search(text: String) -> void: ## Callback for [member search_line_edit]'s input events. Handles highlighting items when navigating with up/down arrow keys. func _on_search_line_edit_gui_input(event: InputEvent) -> void: if event.is_action_pressed("ui_down"): + if scroll_content_container.get_child_count() == 0: + return + search_line_edit.accept_event() var category: Category for i: String in categories: @@ -107,6 +110,9 @@ func _on_search_line_edit_gui_input(event: InputEvent) -> void: scroll_container.ensure_control_visible(category.get_child(item + 1)) if event.is_action_pressed("ui_up"): + if scroll_content_container.get_child_count() == 0: + return + search_line_edit.accept_event() var category: Category for i: String in categories: @@ -160,6 +166,9 @@ func get_previous_visible_category(at: int) -> Category: ## Callback for [member search_line_edit]. Handles emitting [signal node_selected] func _on_search_line_edit_text_submitted(_new_text: String) -> void: + if scroll_content_container.get_child_count() == 0: + return + var category: Category for i: String in categories: var c: Category = categories[i]