noury/cinny
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use Node Hydrogen LTS (#960)

Browse source 
* Use node hydrogen lts in dockerfile

* Use node v18.12.0

* Use node v18.12.0

* Use node v18.12.0

* use lts syntax

* Update Nodejs LTS to v18.12.1

* Update Dockerfile

* Update Dockerfile

* Update readme
This commit is contained in:
Krishan 2022-11-08 20:21:51 +05:30 committed by GitHub
parent 1302682900
commit 4fe4c8bb03
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/build-pull-request.yml vendored
View file

@ -16,7 +16,7 @@ jobs:
- name: Setup node - name: Setup node
uses: actions/setup-node@v3.5.1 uses: actions/setup-node@v3.5.1
with: with:
node-version: 17.9.0 node-version: 18.12.1
cache: 'npm' cache: 'npm'
- name: Install dependencies - name: Install dependencies
run: npm ci run: npm ci
@ -35,4 +35,4 @@ jobs:
with: with:
name: pr name: pr
path: ./pr.txt path: ./pr.txt
retention-days: 1 retention-days: 1

2
.github/workflows/netlify-dev.yml vendored
View file

@ -15,7 +15,7 @@ jobs:
- name: Setup node - name: Setup node
uses: actions/setup-node@v3.5.1 uses: actions/setup-node@v3.5.1
with: with:
node-version: 17.9.0 node-version: 18.12.1
cache: 'npm' cache: 'npm'
- name: Install dependencies - name: Install dependencies
run: npm ci run: npm ci

2
.github/workflows/prod-deploy.yml vendored
View file

@ -14,7 +14,7 @@ jobs:
- name: Setup node - name: Setup node
uses: actions/setup-node@v3.5.1 uses: actions/setup-node@v3.5.1
with: with:
node-version: 17.9.0 node-version: 18.12.1
cache: 'npm' cache: 'npm'
- name: Install dependencies - name: Install dependencies
run: npm ci run: npm ci

2
Dockerfile
View file

@ -1,5 +1,5 @@
## Builder ## Builder
FROM node:17.9.0-alpine3.15 as builder FROM node:18.12.0-alpine3.15 as builder
WORKDIR /src WORKDIR /src

2
README.md
View file

@ -84,7 +84,7 @@ UeGsouhyuITLwEhScounZDqop+Dx
## Local development ## Local development
> We recommend using a version manager as versions change very quickly. You will likely need to switch > We recommend using a version manager as versions change very quickly. You will likely need to switch
between multiple Node.js versions based on the needs of different projects you're working on. [NVM on windows](https://github.com/coreybutler/nvm-windows#installation--upgrades) on Windows and [nvm](https://github.com/nvm-sh/nvm) on Linux/macOS are pretty good choices. Also recommended nodejs version is 16.15.0 LTS. between multiple Node.js versions based on the needs of different projects you're working on. [NVM on windows](https://github.com/coreybutler/nvm-windows#installation--upgrades) on Windows and [nvm](https://github.com/nvm-sh/nvm) on Linux/macOS are pretty good choices. Also recommended nodejs version Hydrogen LTS (v18).
Execute the following commands to start a development server: Execute the following commands to start a development server:
```sh ```sh